Add ADDITIONAL_AIRFLOW_EXTRAS #9032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
reviewed
May 27, 2020
|
Nice! As mentioned before - those should also be added as flags in Breeze, but it can be done separately unless you want to do it @wittfabian ! |
added 2 commits
May 27, 2020 12:49
potiuk
approved these changes
May 27, 2020
potiuk
pushed a commit
that referenced
this pull request
Jun 9, 2020
* Add build-arg ADDITIONAL_AIRFLOW_EXTRAS * Add ADDITIONAL_AIRFLOW_EXTRAS example and description (cherry picked from commit 5a7a3d1)
kaxil
pushed a commit
that referenced
this pull request
Jul 1, 2020
* Add build-arg ADDITIONAL_AIRFLOW_EXTRAS * Add ADDITIONAL_AIRFLOW_EXTRAS example and description (cherry picked from commit 5a7a3d1)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Add build-arg ADDITIONAL_AIRFLOW_EXTRAS * Add ADDITIONAL_AIRFLOW_EXTRAS example and description (cherry picked from commit 5a7a3d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It would be great to be able to pass "ADDITIONAL_EXTRAS" build arg and add extras to the "base" extras of Production Docker image.
Use case / motivation
If someone wants to add just one extra, they might want to specify only that one extra to add rather than copy the whole list
Reference: #8866
We should wait until #9031 is finished, so that there are no surprises and both requests can be merged.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.